check promise before calling it in the android onActivityResult function #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! Happy to merge if you could resolve the conflicts (the error messaging has been changed so we could have consistent messaging across platforms) |
Contributor
|
Nevermind - looks like I can resolve the conflicts through GitHub UI ✔️ |
kadikraman
approved these changes
Jan 6, 2020
Contributor
|
Released in v5.0.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426
Description
onActivityResultis called by all intents when returning to the app from some other location. In the case that we are returning to the app (but not for app auth/or when the intent is null) we trigger a new flow that was added here: #352This new flow expects the
promiseinstance variable to be set. This only happens in some of the other functions in the native module, e.g. theauthorizefunction.This PR ensures that we check if the promise is defined before we call it. Otherwise the app will crash (which is what I was experiencing prior to this PR)
cc @AlgirdasVZ @kadikraman